search

red-hat-storage / odf-console

UI Plugin for ODF Operator.
Apache License 2.0
3 stars 29 forks source link

Update activity card for bluestore-rdr to bluestore migration #1423

Closed TimothyAsirJeyasing closed 2 months ago

TimothyAsirJeyasing commented 3 months ago

https://issues.redhat.com/browse/RHSTOR-5814 https://issues.redhat.com/browse/RHSTOR-5856 https://issues.redhat.com/browse/RHSTOR-5857

TimothyAsirJeyasing commented 3 months ago

if migration complete Screenshot from 2024-06-06 01-30-49 if migration ongoing Screenshot from 2024-06-06 01-30-13 if migration pending Screenshot from 2024-06-06 01-29-01

SanjalKatiyar commented 3 months ago

check why tests are failing...

TimothyAsirJeyasing commented 3 months ago

image

Screenshot from 2024-06-10 18-19-06

TimothyAsirJeyasing commented 3 months ago

/test odf-console-e2e-aws

TimothyAsirJeyasing commented 3 months ago

/test odf-console-e2e-aws

TimothyAsirJeyasing commented 2 months ago

/test odf-console-e2e-aws

SanjalKatiyar commented 2 months ago

plz rebase with latest master...

SanjalKatiyar commented 2 months ago

This PR is missing lot of places to be cleaned-up... that's why CI is failing again and again... plz cross-check properly and clean everything correctly:

  1. create-storage-system/payloads.ts
  2. utils/common.ts
  3. constants/data-protection.ts
  4. create-storage-system/reducer.ts
  5. create-dr-policy/reducer.ts
  6. create-dr-policy/select-cluster-list.tsx
  7. create-dr-policy/selected-cluster-view.tsx
  8. create-dr-policy/select-replication-type.tsx ... cross-check if anything else is needed
SanjalKatiyar commented 2 months ago

As mentioned here: https://github.com/red-hat-storage/odf-console/pull/1423#issuecomment-2223406395, these files as still missing cleanup: create-dr-policy/reducer.ts create-dr-policy/select-cluster-list.tsx create-dr-policy/selected-cluster-view.tsx create-dr-policy/select-replication-type.tsx

TimothyAsirJeyasing commented 2 months ago

Screenshot from 2024-07-15 14-38-43 Screenshot from 2024-07-15 15-27-23

SanjalKatiyar commented 2 months ago

build is failing...

SanjalKatiyar commented 2 months ago

/lgtm cc @bipuladh for approval

SanjalKatiyar commented 2 months ago

/approve cancel

bipuladh commented 2 months ago

/approve /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-console/blob/master/OWNERS)~~ [bipuladh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment