red-hat-storage / odf-console

UI Plugin for ODF Operator.
Apache License 2.0
3 stars 29 forks source link

add info/error messages for SSD/HDD support - LSO mode #1437

Closed SanjalKatiyar closed 3 months ago

SanjalKatiyar commented 3 months ago

https://issues.redhat.com/browse/RHSTOR-5835 https://issues.redhat.com/browse/RHSTOR-5834

LSO configured as part of StorageSystem deployment -

SSDs are detected (not blocking users from deployment):

Screenshot 2024-06-19 at 1 40 25 PM

No SSDs are detected (blocking users from deployment):

Screenshot 2024-06-19 at 1 40 48 PM

LSO pre-configured before StorageSystem deployment -

No SSDs detected (blocking users from deployment):

Screenshot 2024-06-19 at 1 44 43 PM

In case LSO is deleted or any other edge case (not blocking users from deployment, showing a general info message instead):

Screenshot 2024-06-19 at 1 47 12 PM
alfonsomthd commented 3 months ago

LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam

SanjalKatiyar commented 3 months ago

LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam

make sense, will probably add it in a different PR though... it's already getting long due to lot of refactoring...

SanjalKatiyar commented 3 months ago

/test odf-console-e2e-aws

alfonsomthd commented 3 months ago

LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam

@bipuladh :arrow_up: (just FYI)

bipuladh commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-console/blob/master/OWNERS)~~ [SanjalKatiyar,bipuladh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SanjalKatiyar commented 3 months ago

/test odf-console-e2e-aws