Closed SanjalKatiyar closed 3 months ago
LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam
LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam
make sense, will probably add it in a different PR though... it's already getting long due to lot of refactoring...
/test odf-console-e2e-aws
LGTM @SanjalKatiyar If possible, please add some unit tests for the new hooks. Delegating the tagging to @bipuladh @GowthamShanmugam
@bipuladh :arrow_up: (just FYI)
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bipuladh, SanjalKatiyar
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test odf-console-e2e-aws
https://issues.redhat.com/browse/RHSTOR-5835 https://issues.redhat.com/browse/RHSTOR-5834
LSO configured as part of StorageSystem deployment -
SSDs are detected (not blocking users from deployment):
No SSDs are detected (blocking users from deployment):
LSO pre-configured before StorageSystem deployment -
No SSDs detected (blocking users from deployment):
In case LSO is deleted or any other edge case (not blocking users from deployment, showing a general info message instead):