search

red-hat-storage / odf-console

UI Plugin for ODF Operator.
Apache License 2.0
3 stars 30 forks source link

Add option for sessionStorage in useUserSettingsLocalStorage hook #1629

Open SanjalKatiyar opened 1 month ago

SanjalKatiyar commented 1 month ago

PR https://github.com/red-hat-storage/odf-console/pull/1598 added a hook useUserSettingsLocalStorage which provides access to localStorage, need to add an optional prop for sessionStorage as well. ex: https://github.com/openshift/console/blob/master/frontend/packages/console-shared/src/hooks/useUserSettingsLocalStorage.ts

Note: we can talk to OCP team and get this hook exposed as part of SDK as well, instead of copying it on our end.

SanjalKatiyar commented 1 month ago

cc @GowthamShanmugam @bipuladh

GowthamShanmugam commented 1 month ago

Console issue link: https://github.com/openshift/console/issues/14393