red-hat-storage / odf-operator

OpenShift Data Foundation Meta Operator
Apache License 2.0
25 stars 58 forks source link

controllers: delete the webhook created by the ocs-client-operator #462

Closed iamniting closed 2 months ago

iamniting commented 2 months ago

Delete the webhook created by the ocs-client-operator as the client operator is already down in the 4.16.1 and it can not delete the webhook itself. Deleting the webhook will allow us the upgrades from 4.16 to 4.17. Otherwise it will always hit an error "failed calling webhook" while updating the channel of the ocs-client-operator subscription.

Signed-off-by: Nitin Goyal nigoyal@redhat.com

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2304073

iamniting commented 2 months ago

@leelavg I am deleting the webhook where I am verifying the CSV and making the replica count of the OCS-client-operator to 0. This step is after we update the subscription.

Considering that the fix will go in the 4.16 it will work fine as we won't require a subscription change from 4.16 to 4.16 upgrade.

leelavg commented 2 months ago

@leelavg I am deleting the webhook where I am verifying the CSV and making the replica count of the OCS-client-operator to 0. This step is after we update the subscription.

Considering that the fix will go in the 4.16 it will work fine as we won't require a subscription change from 4.16 to 4.16 upgrade.

leelavg commented 2 months ago

LGTM.

iamniting commented 2 months ago

@leelavg I am deleting the webhook where I am verifying the CSV and making the replica count of the OCS-client-operator to 0. This step is after we update the subscription. Considering that the fix will go in the 4.16 it will work fine as we won't require a subscription change from 4.16 to 4.16 upgrade.

  • Ack, until we get the 4.16 build w/ this fix, change in 4.17 isn't effective. Understood correctly?

Yes correct.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/odf-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iamniting commented 2 months ago

/retest

leelavg commented 2 months ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 2 months ago

@leelavg: new pull request created: #464

In response to [this](https://github.com/red-hat-storage/odf-operator/pull/462#issuecomment-2286624169): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iamniting commented 2 months ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 2 months ago

@iamniting: new pull request created: #465

In response to [this](https://github.com/red-hat-storage/odf-operator/pull/462#issuecomment-2286629198): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.