search

red-hat-storage / openshift-cic

CNS Inventory file Creator (CIC) , also works for OCS
GNU General Public License v3.0
31 stars 7 forks source link

Metrics PVC uses default SC with option 'openshift_metrics_cassandra_pvc_storage_class_name' #14

Closed netzzer closed 6 years ago

netzzer commented 6 years ago

Turns out this option needs to have a typo in order to operate correctly, see below. If spelled correctly, cassandra vs cassanda, the specified storageclass is NOT used. Instead the default SC is used if it exists.

Correct option (typo=cassanda) openshift_metrics_cassanda_pvc_storage_class_name=''

johnsimcall commented 6 years ago

This typo appears corrected upstream, but still present in downstream...

# grep cassanda /usr/share/ansible/openshift-ansible/roles/openshift_metrics/tasks/generate_cassandra_pvcs.yaml
        storage_class_name: "{{ openshift_metrics_cassanda_pvc_storage_class_name | default('', true) }}"
        storage_class_name: "{{ openshift_metrics_cassanda_pvc_storage_class_name | default('', true) }}"

# rpm -qf /usr/share/ansible/openshift-ansible/roles/openshift_metrics/tasks/generate_cassandra_pvcs.yaml 
openshift-ansible-roles-3.9.30-1.git.7.46f8678.el7.noarch
netzzer commented 6 years ago

Fixed with PR#17