red-hat-storage / openshift-cic

CNS Inventory file Creator (CIC) , also works for OCS
GNU General Public License v3.0
31 stars 7 forks source link

Totalalloc #32

Closed ramkrsna closed 6 years ago

ramkrsna commented 6 years ago

This resolves #4 . Needs review

netzzer commented 6 years ago

Issue with Cluster 1. Available storage = 100GB, not 133GB. It looks like there is 30% added?

How many nodes are available ?:  7
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com ddd.com
What are the raw storage devices for these hosts(/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 10
How many replicas for logging ?: 50
What is the size for each logging persistent volume (GB) ?: 3
What is the size for each metrics persistent volume (GB) ?: 20
What hosts will be used for CNS logging + metrics backend storage  (IP/FQDN) ?:  fff.com ggg.com hhh.com
What are the raw storage devices for logging + metrics backend on these hosts (/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ? : 100
# * 
# Cluster 1
# Total Storage allocated (GB) = 0
# Total Storage available (GB) = 133
# Cluster 2
# Total Storage allocated (GB) = 231
# Total Storage available (GB) = 100

The 133 GB is due to 4 nodes x 1 device x 100 = 400 / 3.0 = 133 . I belive the total storage available is 133 GB.

netzzer commented 6 years ago

The Warning is good but should be all on one line or at least not have blank lines inserted in the middle of the statement.

How many nodes are available ?:  3
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com
What are the raw storage devices for these hosts(/dev/<device>) ?: /dev/sdb /dev/sdc
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 200
How many replicas for logging ?: 3
What is the size for each logging persistent volume (GB) ?: 20
# Cluster 1
# Total Storage allocated (GB) = 278
# Total Storage available (GB) = 200
Warning one or more persistent volumes are 

larger than the raw storage device size
netzzer commented 6 years ago

Please leave a blank line before and after Cluster1 and Cluster2 reporting. Also get rid of the '*' for some of the scenarios (e.g., choice 3, 4 two cluster).

ramkrsna commented 6 years ago

@netzzer The 133 GB is due to 4 nodes x 1 device x 100 = 400 / 3.0 (replica 3) = 133 . I believe the total storage available is 133 GB.

^^ This is in reference to comment 2.

netzzer commented 6 years ago

Yes, Ramky, You are right about the 4 node condition that if storage device = 100GB then available storage for 4 nodes = 100GBx4 / 3 = 133 GB. My bad.

netzzer commented 6 years ago

Thinking we should add another warning if storage is oversubscribed in addition to having a PV size larger than the storage device. Something like this. User would have to start over similar to Warning for PV size being too large compared to storage device size.

Enter your choice [1-5] : 4
------------------------------------------------------------
For this configuration 7 nodes are recommended
With a minimum of 3 required 
------------------------------------------------------------
How many nodes are available ?:  3                    
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com
What are the raw storage devices for these hosts(/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 50
How many replicas for logging ?: 3
What is the size for each logging persistent volume (GB) ?: 50
What is the size for each metrics persistent volume (GB) ?: 20
# Cluster 1
# Total Storage allocated (GB) = 271
# Total Storage available (GB) = 100
Warning your Total Storage available is less 
than the Total Storage allocated

AND condition could have both Warning messages.

Enter your choice [1-5] : 1
------------------------------------------------------------
 For this configuration 4 nodes are recommended 
 With a minimum of 3 required.
------------------------------------------------------------
How many nodes are available ?:  3
What hosts will be used for application storage (IP/FQDN) ?:  aaa.com bbb.com ccc.com
What are the raw storage devices for these hosts (/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 150
# Cluster 1
# Total Storage allocated (GB) = 150
# Total Storage available (GB) = 100
Warning one or more persistent volumes are
larger than the raw storage device size
Warning your Total Storage available is less 
than the Total Storage allocated
netzzer commented 6 years ago

Issue with choice#5. Need blank line between 'glusterfs' and '[OSEv3:children]'.

Also, for consistency I think adding info about available and allocated storage would be good for choice 5 (I know we decided to now do this but sort of strange without it). Especially for more than 3 nodes is not as intuitive about available storage.

Enter your choice [1-5] : 5
------------------------------------------------------------
For this configuration 4 nodes are recommended 
With a minimum of 3 required.
------------------------------------------------------------
How many nodes are available ?:  4
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com ddd.com
What are the raw storage devices these hosts(/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device(s) ?: 100
# Cluster 1
# Total Storage allocated (GB) = 0
# Total Storage available (GB) = 133

[OSEv3:children]
glusterfs
[OSEv3:vars]
# Container image to use for glusterfs pods
netzzer commented 6 years ago

This is not correct. There should be no Warning for the size of the PV verses the size of the storage device. The 2nd cluster is used for the registry + metrics PV and the storage size = 200 GB. Therefore, 150 GB size for registry PV is NOT larger than 200 GB.

Enter your choice [1-5] : 3
------------------------------------------------------------
For this configuration 7 nodes are recommended
With a minimum of 3 required 
------------------------------------------------------------
How many nodes are available ?:  7
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com
What are the raw storage devices for these hosts(/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 150
What is the size for each metrics persistent volume (GB) ?: 20 
What hosts will be used for CNS metrics backend storage  (IP/FQDN) ?:  ddd.com fff.com ggg.com hhh.com
What are the raw storage devices for metrics backend on these hosts (/dev/<device>) ?: /dev/sdb
What is the size of each raw storage device (GB) ? : 200
# Cluster 1
# Total Storage allocated (GB) = 0
# Total Storage available (GB) = 100

# Cluster 2
# Total Storage allocated (GB) = 176
# Total Storage available (GB) = 266
Warning one or more persistent volumes are
larger than the raw storage device size
netzzer commented 6 years ago

Going to go ahead and merge. Any new fixes should go in new PR.

netzzer commented 6 years ago

This is working better but need to add blank line now between cluster info and the inventory file options [OSEv3:children].

Enter your choice [1-5] : 3
------------------------------------------------------------
For this configuration 7 nodes are recommended
With a minimum of 3 required 
------------------------------------------------------------
How many nodes are available ?:  6
What hosts will be used for application storage (IP/FQDN) ?: aaa.com bbb.com ccc.com
What are the raw storage devices for these hosts(/dev/<device>) ?: /dev/xvdf
What is the size of each raw storage device (GB) ?: 100
What is the size for the registry persistent volume (GB)?: 150
What is the size for each metrics persistent volume (GB) ?: 20
What hosts will be used for CNS metrics backend storage  (IP/FQDN) ?:  ddd.com eee.com fff.com
What are the raw storage devices for metrics backend on these hosts (/dev/<device>) ?: /dev/xvdf
What is the size of each raw storage device (GB) ? : 200
# Cluster 1
# Total Storage allocated (GB) = 0
# Total Storage available (GB) = 100

# Cluster 2
# Total Storage allocated (GB) = 176
# Total Storage available (GB) = 200
# Cluster 2
# Total Storage allocated (GB) = 176
# Total Storage available (GB) = 200
[OSEv3:children]
glusterfs
glusterfs_registry

[OSEv3:vars]