search

red-hat-storage / openshift-cic

CNS Inventory file Creator (CIC) , also works for OCS
GNU General Public License v3.0
31 stars 7 forks source link

ocs.py refers to 3.9 (wasn't it supposed to be fore 3.10?) #46

Closed mykaul closed 5 years ago

mykaul commented 6 years ago

For example: https://github.com/red-hat-storage/openshift-cic/blob/master/ocs.py#L11

ramkrsna commented 6 years ago

@mykaul Yes, it is. At the moment the 3.10 images are not available. We already have that in consideration in this issue https://github.com/red-hat-storage/openshift-cic/issues/41 . We will change it to 3.10 once the images are available on GA. right now it would fail. Hence we have referred to 3.9

mykaul commented 6 years ago

@ramkrsna - that doesn't explain why the 3.10 related code relates to 3.9.

netzzer commented 6 years ago

To fix this issue please remove sentence below from ocs.py and cns.py comment area given it is no longer true. These combos are now supported by CIC: OCP 3.9+CNS 3.9, OCP 3.10+CNS 3.9, OCP 3.10 + OCS 3.10 (after OCS 3.10 GA). 

This tool is very highly version dependent. It is currently configured to work with OpenShift 3.9 and CNS 3.9.

Example for ocs.ppy - https://github.com/red-hat-storage/openshift-cic/blob/master/ocs.py#L11

netzzer commented 5 years ago

File no longer exists now that CIC uses templates.