red-hat-storage / rhcephcompose

A tool to compose releases of Red Hat Ceph Storage for Ubuntu
MIT License
1 stars 1 forks source link

artifacts: sanity-check download() directory args #51

Closed ktdreyer closed 7 years ago

ktdreyer commented 7 years ago

It's easy to accidentally write code that downloads artifacts to a directory that doesn't yet exist. When that happens, download() will quietly write the files to a file named by the "cache_dir" or "dest_dir" arg, rather than writing those files into the respective directories.

To guard against this in new code, sanity-check the directory args to download() and ensure that they really are directories.