Eraden
commented
1 year ago Hi, I think I solved all issues here but unfortunately this ends up being huge PR
Here is what I did:
- Strings where replaces with enum for Machine and Trade, additionally this should prevent some problems with unmatched name and is a little bit faster
- Hash maps have capacity since overflowing them is really slow and requires rehashing every key
- Into screen was fixed
- Typos were removed
- Some float operations were fixed
Note:
Some inline attributes where removed. Be careful with them and note they are not c++ inline, they are only useful in libraries since they are instruction for compiler this part should be inline in user application not in current library
Nereuxofficial
Hey, thank you so much for implementing this! We really appreciate it. It looks good except for the holes being in a broken state and their indicator being present because our check for them is really primitive. I will review it in the following days :)