search

red-scorp / SoftSPIB

Software SPI class for Arduino with support of not 8-bit aligned transfers
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Adding CI build action (and fix usage of deprecated SPI APIs) #4

Closed aentinger closed 1 year ago

aentinger commented 1 year ago

This repository was flagged during semi-automatic review for using any of the SPI APIs setBitOrder, setDataMode, setClockDivider. Unfortunately those SPI APIs are only supported within ArduinoCore-avr and deprecated everywhere else.

This is problematic because the library.properties of this library indicates that any architecture is supported (architectures=*) as it raises expectations by the user that simply can not be fulfilled when using this library on any platform that does not support those SPI APIs.

By donating this PR I'm hoping to start a conversation of either limiting the list of supported architectures to avr

-architectures=*
+architectures=avr

or to adapt the code to use the SPISettings API supported in all cores.

red-scorp commented 1 year ago

Thanks for the contribution. I'll have a look on SPISettings API later. No time now, sorry. WBR, Andriy

aentinger commented 1 year ago

You are welcome =)