search

red5pro / react-native-red5pro

React Native Red5 Pro Publisher/Subscriber
https://www.red5pro.com/
Other
35 stars 20 forks source link

Red5 Pro SDK filepath is wrong within code(Android) #66

Open logandhead opened 4 years ago

logandhead commented 4 years ago

To install on android, you must manually edit a file to link the red5pro jar file. This seems to be a flaw because every time someone builds the node modules it requires you to go in every time to update the file path.

I'd suggest changing the code needing to be edited to: 

dependencies {
    implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
    implementation files("../../../android/app/libs/red5streaming.jar") 
}

this will work for all react-native projects using the library because the file directory structure more than likely the same.

chungweileong94 commented 4 years ago

Currently, the best workaround for me is to use patch-package to handle the linking during the post-install.

logandhead commented 4 years ago

Thanks @chungweileong9! Going to still keep open because I think that there should still be a fix to the source code and we should not be required to use patch-package.

anmolsharma0002 commented 3 years ago

Execution failed for JetifyTransform: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar.

Transform's input file does not exist: E:\web1experts\Galaxy\GalaxyApp\node_modules\react-native-red5pro\android\app\libs\red5streaming.jar.