red5pro / red5pro-simple-auth-plugin

SimpleAuth Plugin
https://www.red5pro.com/docs/server/authplugin.html
Apache License 2.0
3 stars 6 forks source link

RoundTripAuthenticationValidator docs show type is passed invalidate callback #2

Open D010101 opened 5 years ago

D010101 commented 5 years ago

The docs for the RoundTripAuthenticationValidator state that the "type" is passed in the invalidate endpoint call: https://github.com/red5pro/red5pro-simple-auth-plugin/blob/master/red5proroundtripauthvalidator.md#invalidate-credentials

However, the type parameter is not passed in the call. I looked at the code and the invalidate callback appears to only apply to publisher connections, not subscriber connections. https://github.com/red5pro/red5pro-simple-auth-plugin/blob/aa098939cf1d3534a835d89ea9110dbe923a5742/src/main/java/com/red5pro/server/plugin/simpleauth/datasource/impl/roundtrip/RoundTripAuthValidator.java#L565

Not sure if just the docs need to be corrected, or if the functionality in the invalidate is missing the type parameter in the invalidate callback.

rajdeeprath commented 5 years ago

I believe it will be a doc update. invalidate is used to destroy the token which is obtained through /login call to the remote server. Since the token is not issued based on type, the invalidate call too does not need the type parameter.