search

red6 / pdfcompare

A simple Java library to compare two PDF files
Apache License 2.0
220 stars 66 forks source link

Use specific configuration file OR prefix configuration entries with e.g. "pdfcompare" #40

Closed danile42 closed 4 years ago

danile42 commented 6 years ago

Since pdfcompare uses the default configuration file name "application.conf", it will probably share this file with other libraries that also use Typesafe config. To avoid confusion, pdfcompare should either use a custom file (e.g. "pdfcompare.conf"), or add prefixes to its property keys (e.g. "pdfcompare.allowedDifferenceInPercentPerPage"). Typesafe config allows easy handling of such namespacing prefixes.

finsterwalder commented 6 years ago

Hi Danile,

thanks for the hint. I didn't think about that. I would prefer a different file name over prefixes, since prefixes would make the entries very long. I will look into that...

finsterwalder commented 4 years ago

I will probably not change this, since noone reported a real problem. It's very unlikely, that there will be actual collisions between keys.

finsterwalder commented 4 years ago

A different configuration file can be provided via command line arguments (see README) or via a custom ConfigFileEnvironment.