redCOMPONENT-COM / redSHOP

redSHOP - a powerful e-commerce for Joomla
http://redcomponent.com/
GNU General Public License v2.0
25 stars 24 forks source link

4.0.0_beta - id´s needs to be unique - seo enhancement #5635

Open Rmh1978 opened 1 year ago

Rmh1978 commented 1 year ago

What version of redShop has the issue? 4.0.0_beta

What version of Joomla has the issue? 4.3.4

What php version has the issue? - Can be found Joomla Home dashboard > Site Information. redShop is for min. php8 8.0.30

What view did you experience the issue? - e.g. Site > product detail view Site category view with filters

What did error reporting state? - Can be enabled in Joomla Backend > System > Global Configuration > Server > Error Reporting= Maximum N/A

What did Chrome inspector console state? - Right-click on the page and click "Inspect" Found 3 elements with non-unique id #category_template: Found 3 elements with non-unique id #manufacturer_id: Found 3 elements with non-unique id #order_by:

Describe the issue The 3 id´s needs to be unique for each filter form

Fix - If you have already made a fix but unable to do it on Github then write it here The files to edit is here: libraries/redshop/layouts/tags/category/filter_form.html.twig libraries/redshop/layouts/tags/category/orderby_form.html.twig libraries/redshop/layouts/tags/category/template_selecter_form.html.twig

I didnt investegate if it has any negative effect simply renaming the id´s.