search

redVi / voyager

Just another jekyll theme.
MIT License
45 stars 63 forks source link

Add relative link of tag in the aside.html #5

Closed yeshuanova closed 7 years ago

yeshuanova commented 7 years ago

Hi redVi

I find an error link in aside.html and update relative path.

Besides, about "image path" config and relative url, the image won't be found if we set baseurl and image path as "{baseurl}/assets/images" form at the same time.

For example, the baseurl is "/blog" and images path is "/blog/assets/images". The 404 error will be happened because the full path will be "/blog/blog/assets/images/*", the duplicated relative url is occurred.

Because the origin layout uses the site.images setting in many positions. Maybe we can notice users this situation and must add relative url filter at markdown linking path.

redVi commented 7 years ago

Yes you are right. Thanks for pull request. I'll correct description in the readme. And then I should to check and change head.html: all points when og/twitter tags are used.