search

redacademy / it-winter-2018

2 stars 2 forks source link

move js libraries from js folder #1

Open resonantdoghouse opened 6 years ago

resonantdoghouse commented 6 years ago

I think I know why these were moved from the lib folder to the js folder. Basically there's a line in the dploy.yaml which is ignoring the sub directory.

However you should move the js libraries to a different location e.g. maybe a lib folder in the root of your theme instead of the js folder.

The issue at the moment is eslint is going to complain about the libraries and gulp is also going to minify the files.

Another option is to use the cdn version of the js files.

GPChappell commented 6 years ago

Need to talk to Jim for more details on how to specifically fix this

rcass commented 6 years ago

is this still an issue @resonantdoghouse @GPChappell ?

If so, could we resolve it tomorrow maybe?