search

redacademy / it-winter-2018

2 stars 2 forks source link

front-page.php: Organization and Comments #18

Open rcass opened 6 years ago

rcass commented 6 years ago

Since the front page is quite huge and has loops within loops, I think there needs to be added comments and clean up the indentation to make things more clear.

I also noticed that there is this line at the top of the page https://github.com/redacademy/it-winter-2018/blob/aadfa0eae0dad1c4deb8156a34b7773247323aa9/themes/instanttheatre/front-page.php#L16

Which is probably not necessary, since it is the front-page.php template which can only be used on the front page. I would try cleaning up and removing it, then you can probably just us the_title for the title

rcass commented 6 years ago

Also view the page source on your front-page. To me it looks like things could be cleaned up, so the output is a little cleaner. (Aka remove extra divs, change comments so they don't appear in the page source)

You will also find if you run that page source through the HTML validator, there are errors to resolve.

rcass commented 6 years ago

Just wanted to checkin on this issue since it does not look complete yet.

I see @sslnyx you are assigned to this issue, is this coming along?

sslnyx commented 6 years ago

front page code indented added comments for each section.