search

redacademy / it-winter-2018

2 stars 2 forks source link

Post Types: Translatable Strings & Code Consistancy #27

Closed rcass closed 6 years ago

rcass commented 6 years ago

In the functionality plugin, I noticed that when registering the custom post types some of the post types had translatable strings __x( ) and some do not.

Basically, this functions but for the sake of code quality you need to agree on how you want this written.

Either with translatable strings: screen shot 2018-03-22 at 4 17 40 pm Or no translatable strings: screen shot 2018-03-22 at 4 17 48 pm

Decide as a group how you want to format the code and adjust please 👌

rcass commented 6 years ago

If it helps, custom taxonomies that are registered do not have translatable strings. So you will need to be consistent with custom post types and custom taxonomies.

GPChappell commented 6 years ago

All CPT now declared in same style. commit 64988ccb514099cace874908b74147143bcc796d