search

redacademy / wild-spring-2018

3 stars 0 forks source link

About.php and Dynamically Generated Menu #15

Open rcass opened 6 years ago

rcass commented 6 years ago

In about.php I noticed that you are just hard coding the menu. https://github.com/redacademy/wild-spring-2018/blob/d8717dab4a094c07bd37105c942ea306f731405e/themes/wav-theme/page-templates/about.php#L13-L22

This might be a good interm solution, but if the client ever wants to change the menu, they will need to go into the php :/

Is there a reason for not dynamically generating the menu here? 🤔

pinaska commented 6 years ago

This about-page-only menu is only used for navigation through this page sections. It does not contain external links.

rcass commented 6 years ago

Oh I see. Okay in that case I would still create (register in functions.php) a new menu, so the client has access to this menu and can make changes.

Then under the menu items just create custom links. As a custom link to can chose the link label (ex: Press) and also the link (ex: set it to #pressJump)

Basically even through it is just jumping to different sections on the page, it still can be a dynamically generated menu (and accessible to the client).

pinaska commented 6 years ago

ok, we will address this. Thank you