redacademy / wild-spring-2018

3 stars 0 forks source link

HTML Classes: Chose a writing convention #16

Open rcass opened 6 years ago

rcass commented 6 years ago

I noticed throughout the php files the writing of class names is not consistent.

Some times if is camel case https://github.com/redacademy/wild-spring-2018/blob/d8717dab4a094c07bd37105c942ea306f731405e/themes/wav-theme/page-templates/about.php#L137 and other times it is kebab case https://github.com/redacademy/wild-spring-2018/blob/d8717dab4a094c07bd37105c942ea306f731405e/themes/wav-theme/page-templates/about.php#L175

Best practice is to chose on style of writing! A lot of the default styles use kebab styles, so I suggest using those just for the sake of consistency.