search

redacademy / wild-spring-2018

3 stars 0 forks source link

Filickity: Remove data-flickity (if using jQuery to customize) #9

Open rcass opened 6 years ago

rcass commented 6 years ago

Not quite sure what is going on with your carousels, but I see jQuery customizing it, so you dont need the inline HTML.

data-flickity='{ "watchCSS": true } so just delete this. And all your customizations should be done via jQuery.

Best to just to stick to one method of customization rather than having both.

rcass commented 6 years ago

Found another one in about.php to possibly remove https://github.com/redacademy/wild-spring-2018/blob/d8717dab4a094c07bd37105c942ea306f731405e/themes/wav-theme/page-templates/about.php#L62

pinaska commented 6 years ago

According to the documentation from flickity plugin page, I wrote watchCSS directly in html, on php page. I will address moving all flickity related code to .js file once we have all the carousels working. Can it be this way?