redacted / XKCD-password-generator

Generate secure multiword passwords/passphrases, inspired by XKCD
BSD 3-Clause "New" or "Revised" License
1.32k stars 185 forks source link

French words list could be better #115

Closed webafrancois closed 3 years ago

webafrancois commented 4 years ago

I'm french speaker. French words list aren't good. Many accents are not respected : We can read :

I submit a corrected list with accents, without words with ".", and without duplications. The old list count : 276506 words (which contains all words in double)

The new list contains : 138253 words.

proper-french-list.tar.gz

redacted commented 4 years ago

Hi! Apologies for the delay in getting to this.

Which word list are you seeing the issue in? I ran some tests with fr-freelang and fr-freelang-bernard-vivier and see correct accenting, and only ~23k entries.

I'm more than happy to add another French list though - can you confirm where it originated to ensure the licences are OK?

webafrancois commented 4 years ago

I took the french list in your README.rst of this repository

French: Cleaned version of this list. Public domain.
https://packetstormsecurity.com/files/download/32007/french.gz

You mention that is a Public Domain, but there is no licence in the .gz file But this file isn't correctly written. I correct it and publish on this post.

StudioEtrange commented 3 years ago

Please incorporate this proposed dictionnary because fr-freelang and fr-freelang-bernard-vivier have injurious words ! like "salope" => means bitch or "viol" => means rape

redacted commented 3 years ago

Thank you for your contribution - these changes have been made in v1.17.4 or later

Cor-J commented 3 years ago

Hello, The wordlist provided by @webafrancois is in utf8, which isn't correctly read by KeepassXC on windows. Here is a cp1252 version which correctly shows accentuated letters. cp1252_french.txt