search

redacted / XKCD-password-generator

Generate secure multiword passwords/passphrases, inspired by XKCD
BSD 3-Clause "New" or "Revised" License
1.32k stars 185 forks source link

Add randomized delimiters #132

Closed sean-abbott closed 3 years ago

sean-abbott commented 3 years ago

This allows xkcdpass to generate passwords that meet the "strong password" requirements of many websites, without losing the memorizable nature of the word list, a la the xkcd comic.

At least if you know symbol pronunciations like "bang" for !

I know you did this in your example post processing, but I think it's nice to just build into the default command line tool.

If you agree, I'll fix the tests and add any new ones that make sense.

adambirds commented 3 years ago

@sean-abbott if you're interested in contributing this to xkcd-pass I will happily have this merged for you.

sean-abbott commented 3 years ago

That'd be great! Lemme know if there's anything else I need to do for it.

On Thu, Apr 29, 2021 at 5:18 PM Adam Birds @.***> wrote:

@sean-abbott https://github.com/sean-abbott if you're interested in contributing this to xkcd-pass https://github.com/adambirds/xkcd-password-gen I will happily have this merged for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redacted/XKCD-password-generator/pull/132#issuecomment-829602824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWJV7DYZFKVMBSKLNLXVDTLHEKJANCNFSM4VXYH6UA .

adambirds commented 3 years ago

@sean-abbott my codebase has been changed slightly to neaten it up and it has 100% test coverage so would just need you to make the commit work with slightly updated code base and write tests for it that work.

sean-abbott commented 3 years ago

Cool beans, I'll do that soon.

On Thu, Apr 29, 2021 at 6:05 PM Adam Birds @.***> wrote:

@sean-abbott https://github.com/sean-abbott my codebase has been changed slightly to neaten it up and it has 100% test coverage so would just need you to make the commit work with slightly updated code base and right tests for it that work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redacted/XKCD-password-generator/pull/132#issuecomment-829626086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWJVZ57PUUVZ7PMA5J3JDTLHJZLANCNFSM4VXYH6UA .

sean-abbott commented 3 years ago

Oh, sorry, didn't notice you were running a fork/new project lemme take a looksee.

adambirds commented 3 years ago

Yes @sean-abbott, I explain the differences and reasons for going a separate way here. But the basics is so its active, neaten up the codebase, 100% test coverage, neaten the output, set some useful defaults to meet most password requirements and some extra features like random appended digits on the end.

redacted commented 3 years ago

@sean-abbott my sincere apologies for the delay in addressing your PR, it is now merged and live on pypi. If you have any issue with the phrasing I chose in the README please let me know and I will include your fixes

@adambirds Thank you for you efforts in improving on xkcdpass. I'd love to discuss this further - ideally to square away the licensing and, if possible, whether any of your fixes/improvements could be upstreamed given the GPL

sean-abbott commented 3 years ago

No worries, glad to get it sorted, and apologies to all for my confusion!

On Wed, May 5, 2021 at 9:42 PM Steven Tobin @.***> wrote:

@sean-abbott https://github.com/sean-abbott my sincere apologies for the delay in addressing your PR, it is now merged and live on pypi. If you have any issue with the phrasing I chose in the README please let me know and I will include your fixes

@adambirds https://github.com/adambirds Thank you for you efforts in improving on xkcdpass. I'd love to discuss this further - ideally to square away the licensing and, if possible, whether any of your fixes/improvements could be upstreamed given the GPL

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redacted/XKCD-password-generator/pull/132#issuecomment-833163041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWJV3LZC3EH4B2IBXYVZTTMHXYJANCNFSM4VXYH6UA .