search

redacted / XKCD-password-generator

Generate secure multiword passwords/passphrases, inspired by XKCD
BSD 3-Clause "New" or "Revised" License
1.32k stars 185 forks source link

as-is case #144

Closed chkpnt closed 1 year ago

chkpnt commented 2 years ago

It would be nice to have an option to keep the case as given in the wordlist.

At least in the German wordlist, lots of words are already capitalized as nouns are always capitalized.

Furthermore, I've added two missing tests and did some chore regarding PEP8 which my IDE (PyCharm) observed.

chkpnt commented 2 years ago

Btw: test_loadwordfile fails on my machine.

xkcd_password doesn't find the passed wordlist, so it uses eff-long, which results in a length of 5670.

grafik

But dunno, may be it's just a configuration issue on my side, so I haven't changed anything.

Sol7469 commented 1 year ago

I just wanted to submit a pull request for this. Then I saw, there is already one. My solution is nearly the same. I would realy appreciate this new option for switching case.

Thanks @chkpnt

chkpnt commented 1 year ago

Any thoughts about this, @redacted?

redacted commented 1 year ago

Hey, apologies for the delay in getting back to you on this. Looks good to me, merged!