Binding to redux improvements

redapesolutions / react-redux-counter1

0 stars 0 forks source link

Binding to redux improvements #3

Open matiboy opened 7 years ago

matiboy commented 7 years ago

[ ] improve the mapStateToProps to avoid allowing access to the whole object: what is actually really needed in the component?
[ ] make use of mapDispatchToProps correctly: do not use dispatch in the props, but rather map the real actions that are needed: increment, decrement and reset

mingsterism commented 7 years ago

Problem 1 in logs, state in mapStateToProps is counter.js mapStateToProps --------- {counterReducer: {…}}counterReducer: counter: 0__proto__: Object__proto__: Object what is really needed is just counter, not counter2.

Problem 2 Not enough time. Will look over weekend.