search

redapesolutions / react-redux-counter1

0 stars 0 forks source link

Recompose (tougher #1) #5

Open matiboy opened 7 years ago

matiboy commented 7 years ago
mingsterism commented 7 years ago

I built a new counter called Counter1.js I got most of it working. However, I dont think I'm doing some parts correctly. Counter1.js

File: Counter1.js Line 16, 19 : Should be using redux dipatch methods INCREMENT, DECREMENT. I'm currently not using the functions stored in counterReducer1.js

Line 41: For the Value to modify increment, decrement by, I need to access it in state which is on Line 53. However, I wasnt too sure if its using setState to modify state, like a traditional react input field.

Line 48: I believe the entire state is stored in this function. However, am not too sure.

Line 24: This method should not be in this HOC as this is buttonEnhance. I believe it should be in another HOC called inputEnhance

I worked mostly with this problem as once I worked on a particular problem set, I get familar with it and can build on it further, mostly by trial/error and guessing how it worked.

Will work on it further over the weekend.

matiboy commented 7 years ago

Great, looking forward to what you can come up with and I'll chip in where I can