redbadger / pride-london-app

Pride in London mobile app
MIT License
85 stars 22 forks source link

There isn't much vertical space for viewing categories in filter when device is landscape #132

Open declanslevin opened 6 years ago

declanslevin commented 6 years ago

Description of issue

When viewing the categories filter with the device orientated horizontally, the amount of vertical space for displaying the categories is rather limited, so that you can only see a few listed at a time. The Cancel/Clear all buttons, Show me label and selected filters widget take up almost 50% of the available vertical screen space.

Expected behaviour

This is probably one for UXD to look at.

Might be an idea to combine the Show me label and selected filters widget into a single line when orientated horizontally (at the very least - might be able to squeeze the Cancel/Clear all buttons on to the line as well?). Perhaps reduce the height that the Cancel/Clear all buttons are given. Maybe the CTA (Show x events) button height could be reduced in horizontal orientation.

Steps to reproduce

OS / Browser / Device model

Galaxy S8 (8.0) Physical iPhone 6 (10.3.3) Physical

Screenshots

Galaxy S8 screenshot_20180416-103942_pride alpha

iPhone 6 img_0035

JunBadger commented 6 years ago

For landscape view on the filter by categories, can we make the header non-sticky but keep the CTA sticky.

Also, another issue - the background colour on the category selection is not rendering on landscape view.

declanslevin commented 6 years ago

I have already logged the selection highlight issue under #129

JunBadger commented 6 years ago

Here's the landscape view without the sticky header. Can we please bring in the content to fit the 440px landscape grid:

category filters - landscape

zpl.io/adMM51n