search

redbadger / react.london

:star2: react.london conference & community website :star2:
https://react.london
10 stars 3 forks source link

Added css to check for empty hrefs and adjust links accordingly #225

Closed AndrewBestbier closed 8 years ago

AndrewBestbier commented 8 years ago

Alt Text

Motivation

Upon a further review, the great @lpil discovered that, if the calendar links have no link provided on Prismic they still have the same hover state and link react.london. This behaviour is, well, undesirable.

So dear reviewer, I have to change my stance (hatred) of css upon finding this lovely snippet:

&[href^="http"] {
    //css here
}

This selects for elements which have an href, and an href that starts with "http". My goodness.

So I added this styling on our calendar/map links on both the community and conference sites.

Thanks for the review!

asavin commented 8 years ago

Achievement unlocked for the best written PR motivation 🏆