Concurrent featured events - Githubissues

redbadger / react.london

:star2: react.london conference & community website :star2:

https://react.london

10 stars 3 forks source link

Concurrent featured events #277

Closed lazydevorg closed 7 years ago

lazydevorg commented 7 years ago

Featured events now can be more than one.
A Read more button has been added to the featured events to show the details about the speakers.
An optional event's description has been added.

grahammendick commented 7 years ago

There are a couple of items that don't match the designs:

Before the Read More is clicked the Speaker Info is below the image but it should be to the right
In Tablet screen mode, the Speakers shift slightly when Read More is clicked

lazydevorg commented 7 years ago

@grahammendick it has been decided after to not move the speakers' info from right to bottom. I think we decided to leave them on the bottom.

samsmithyeah commented 7 years ago

The August React London Meetup event has ended. But it says 'tickets now sold out' on the page, when it should say 'this event has ended. watch the video here'

lazydevorg commented 7 years ago

@samsmith1983: I've fixed it. Have a look please

samsmithyeah commented 7 years ago

Another issue: date is not showing when event is set to PRE_RELEASE and ticket release date is set

samsmithyeah commented 7 years ago

The 'read more' button does not appear to be working on Android Chome 6.

samsmithyeah commented 7 years ago

Another issue: This is what the page looks like in iOS9 Safari: screen shot 2016-12-23 at 10 53 43

lazydevorg commented 7 years ago

The 'read more' button does not appear to be working on Android Chome 6.

I've tried and it seems to work. @samsmith1983 can you give more details about the device you used?

samsmithyeah commented 7 years ago

@lazydevorg this is on a Samsung Galaxy S7, via browserstack. I'll grab a couple of physical devices to confirm now.

samsmithyeah commented 7 years ago

The 'read more' issue was due to 'safe mode' being enabled on the test device. All good now.

lazydevorg commented 7 years ago

Another issue: This is what the page looks like in iOS9 Safari:

@samsmith1983 can you please create an issue for this? It was an already existing problem and it makes sense to work on it separately.

samsmithyeah commented 7 years ago

@lazydevorg yep, didn't notice this was happening before. Will create an issue now.

samsmithyeah commented 7 years ago

It's actually already logged under #276

samsmithyeah commented 7 years ago

OK so the 'read more' issue appears to only happen with Javascript is disabled. Need to confirm whether this is a blocking issue or not.