redbadger / react.london

:star2: react.london conference & community website :star2:
https://react.london
10 stars 3 forks source link

Speaker list #302

Closed JRGranell closed 7 years ago

JRGranell commented 7 years ago

A re-working of the speaker list

asavin commented 7 years ago

As discussed with @Roisi and @AmyBadger

samsmithyeah commented 7 years ago

There's some inconsistency with the Become a speaker button text colour. On the homepage, it's white: screen shot 2017-01-26 at 13 53 40

On /speakers it's sort of grey (and less bold): screen shot 2017-01-26 at 13 54 30

And in the design it's the same colour as the background: screen shot 2017-01-26 at 13 54 10

samsmithyeah commented 7 years ago

Mobile version of speakers page doesn't seem to be there:

img_0056 png

samsmithyeah commented 7 years ago

Not sure how much we care about IE11 with RL, but... On IE11, the speakers on the homepage only ever has 2 columns (should be 3):

screen shot 2017-01-26 at 15 10 23

samsmithyeah commented 7 years ago

On the speakers page, the mobile breakpoint doesn't seem to be wide enough. Larger screened mobiles (like iPhone 6 plus and Pixel XL) don't get the mobile version:

screen shot 2017-01-26 at 15 40 14

samsmithyeah commented 7 years ago

Mobile looking good now.

Only remaining known issue is IE11 thing, which we could possibly fix post release?