Add meta information for social networks

redbadger / react.london

:star2: react.london conference & community website :star2:

https://react.london

10 stars 3 forks source link

Add meta information for social networks #331

Closed Etiene closed 7 years ago

Etiene commented 7 years ago

This should add meta information for sharing links of react london on twitter or facebook
You should test it here, for example: https://developers.facebook.com/tools/debug/og/object/

gregdorward commented 7 years ago

@asavin / @Etiene is this how you would expect the sharing link to look? I haven't seen any designs for this, so I'm hoping you have?

asavin commented 7 years ago

@gregdorward yeah that doesn't look great

gregdorward commented 7 years ago

Shall we get UX input on this one then?

asavin commented 7 years ago

@gregdorward yes

gregdorward commented 7 years ago

@stevecottle - do you have an opinion on the screenshot shown above? This is what a user would see if they shared the React London site on Facebook or Twitter. Do you think it needs resizing, or a different image altogether?

Etiene commented 7 years ago

@gregdorward there is a bug to be solved concerning the server rendering that @asavin pointed yesterday! I'll flag with a ready for test once this is solved

Etiene commented 7 years ago

Unfortunately I think it won't be possible to do a branch test on this feature because facebook will still scrape the canonical url from react.london and not from our staging url. We will have to deploy this first and double check. cc @stevecottle @gregdorward

gregdorward commented 7 years ago

Ok @Etiene, if that's the case we'll just have to check it in production. Will the link you provided still be the way to test in once it's there?

Etiene commented 7 years ago

@gregdorward yes, it will be the same facebook url

gregdorward commented 7 years ago

Is this what you were expecting after this change @Etiene ?