search

redbadger / react.london

:star2: react.london conference & community website :star2:
https://react.london
10 stars 3 forks source link

display career brief for an organisation instead of description #339

Closed dstodolny closed 7 years ago

dstodolny commented 7 years ago

Important badger-brain PR should go first

gregdorward commented 7 years ago

I'm getting a 500 server error when trying to access the build generated by this PR - does anyone know what might be causing that? I've tried rebuilding in CircleCI, but that had no effect

Etiene commented 7 years ago

@gregdorward this is probably because badger brain needs to be deployed first. cc @asavin

gregdorward commented 7 years ago

@stevecottle could you take a look at the output of this one to see if you're happy with it please? The career brief shown in this screenshot replaces the description we are currently displaying

screen shot 2017-02-23 at 14 48 28
gregdorward commented 7 years ago

This one still needs a code review, as it currently has no approvers

gregdorward commented 7 years ago

Holding off on merging until we have the copy for career briefs set up in production

dstodolny commented 7 years ago

Oh yeah. We should test it locally using production prismic data. You should make amendments in your .env file. And make sure you're running badger-brain

gregdorward commented 7 years ago

@dstodolny, you mentioned ASOS, but the following companies also don't have any data returned when running the query against Badger Brain in production. I just wanted to check if this is expected?

{ "name": "Bloomberg", "careerBrief": null }, { "name": "Magnolia CMS", "careerBrief": null }, { "name": "DevelopHer", "careerBrief": null }, { "name": "Bitgenics", "careerBrief": null }, { "name": "Red Badger", "careerBrief": null }, { "name": "Ticketmaster", "careerBrief": null }, { "name": "Twilio", "careerBrief": null }, { "name": "Zalando", "careerBrief": null }, { "name": "Code Your Future", "careerBrief": null },

gregdorward commented 7 years ago

Ok, I've tested this one running the branch locally against production data from Badger Brain. The careerBrief data is being displayed where the description was once held - This one is good to be merged