redbadger / react.london

:star2: react.london conference & community website :star2:

https://react.london

10 stars 3 forks source link

Post Conference stage #348

Closed romanschejbal closed 7 years ago

romanschejbal commented 7 years ago

Based on these

How to test

To fake (for testing purposes only as it'll be removed later) the 1st stage of post conference state, put this at the end of the url /post-conference. For the 2nd stage it is /post-conference-final

Todo

Stage 1

[x] Update ConferenceAbout box
[x] Instagram photos
[x] Tweets
[x] Headings include icons
[x] Change hashtag to #ReactLondon2017

Stage 2

[x] Linkedin Slides from Slideshare
[x] Youtube playlists
[x] Photos on Flickr (6 photos instead of 3)

Before Merge - Stage 1

[ ] Change home route to point the new post conference state (see shared/routes/conference-routes/index.js)
[ ] Update instagram section with real data
[ ] Update twitter section with real data

Before Merge - Stage 2

[ ] Update route to pass down finalStage prop (in shared/routes/conference-routes/index.js)
[ ] Update flickr section with real data
[ ] Update youtube playlists with real data
[ ] Update slideshare presentations with real data

chris-brookes commented 7 years ago

@romanschejbal - There is a 'finished' misspelling in a header and the dash lines are missing between each set of photos/messages. (on both postconference and postconferencefinal pages) See image attached.

screen shot 2017-03-17 at 14 33 31

Wrong twitter tag. Should be "#ReactLondon2017"

screen shot 2017-03-17 at 15 03 31

romanschejbal commented 7 years ago

Thanks for reviewing guys.. Couple things

[x] The styling looks odd on a medium screen size, where there’s only one stretched image per section. - It should show 3 images on tablet or 1 image on screen smaller than tablet (portrait) does not that work for you?
[x] The styles on the buttons should match the styles on the current ‘See more’ button on the home page. Same border radius etc.
[x] The html for the speaker youtube and slides should look more like the html on the current home page. With the images inside figure tags and all the text inside h5 tags.
[x] Instead of using background images for the youtubes, img tags would be more accessible. - I can't use img tag since the images might have different proportions. So I'm using background-size: cover. Unless there is a better of solving this?
[x] Should there be rel="noopener" on links that open in new windows like in other areas to the site?

Screen to design inconsistencies

[ ] Mismatch between the play arrow image on the youtubes - still need to implement (missing icon)
[x] Missing dashed lines between sections
[x] Larger gap above See all photos button
[x] Flickr section instead of Facebook section - we won't be using Facebook
[x] Wrong hashtag in Twitter section

chris-brookes commented 7 years ago

There is a space layout issue with the win10 IE11 browser. A similar issue appears on other pages of the site, but after looking at the browser usage stats we decided to leave the issue, so I will do on this page too.

Still waiting for the new youtube play arrow image.

chris-brookes commented 7 years ago

@asavin - We need to change the twitter #title again. Change from #ReactLondon2017 to #ReactLondon Places to change:

In the h3 twitter header
Text in the button
The link in the button (on both post conference pages)