search

redbadger / website-next

DEPRECATED incarnation of Red Badger company site
https://redbadger.github.io/website-next/
6 stars 2 forks source link

Fix navigation order, remove 'active' highlight for now #211

Closed tabazevedo closed 7 years ago

tabazevedo commented 7 years ago

This updates the ordering to the new one as @Monikamu mentioned here https://github.com/redbadger/website-honestly/issues/200

Previously the underline was hardcoded, and to support the architecture of universal rendering, we'd need to read the URL from state, and work out which link to underline based on that. Unfortunately, I ran into an issue where I could not use redux connect on the container which rendered the navigation, making it impossible to access store state.

Spent 2-3 hours attempting to debug, and after discussing with Andrew and confirming with Sari, we've decided it best to not spend more time for now - website-next only handles the Events and Join Us pages currently, which both have clear titles. It should be a straightforward fix if we transition these to the website-honestly architecture, otherwise we can dedicate more dev time if we don't end up transitioning.

Lets discuss Monday when Alex is back.

JoeStanton commented 7 years ago

Agree with the above. Merging this and we can discuss further on Monday.