redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.87k stars 127 forks source link

slurp files as bytes to avoid errors trying to decode, and clarify sr… #253

Closed EdwardLarson closed 1 year ago

EdwardLarson commented 1 year ago

…c dirs should only be src

Follow up to https://github.com/redballoonsecurity/ofrak/pull/249

One sentence summary of this PR (This should go in the CHANGELOG!)

Link to Related Issue(s) If the source_dir contained any binary sort of files, errors were likely when trying to read them as strings.

Please describe the changes in your request. Slurp and store source directories as raw bytes, not strings (there is no need for them to be strings)

Anyone you think should look at this, specifically? @marczalik