redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.87k stars 127 forks source link

Normalize GUI script tests, use regex to ignore potentially volatile values #279

Closed marczalik closed 1 year ago

marczalik commented 1 year ago

Which files would be affected? test_ofrak_server.py, which currently tests against exact values returned by ScriptBuilder as lists of strings. The tests can be improved by treating the scripts as strings, and by replacing potentially volatile values that may change in the future so that they don't break the test when nothing has functionally changed.

Link to comment discussing the reasoning for this ticket and suggested approach.

Does the proposed maintenance include non-doc string functional changes to the Python code? Yes

Are you interested in implementing it yourself? Yes