redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

Fix `test_create_mapped_child` #280

Closed marczalik closed 1 year ago

marczalik commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Previously, test_create_mapped_child could fail randomly if the first result in unpack was a resource without data to carve. This PR uses the first result of get_children instead, which is now deterministically ordered, so the test should no longer attempt to carve a resource without data.

Link to Related Issue(s) N/A

Please describe the changes in your request. Call create_mapped_child on results of get_children instead of unpack.

Anyone you think should look at this, specifically? @whyitfor @rbs-jacob