[ x] I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fix bug where Component External Tool would raise an error when checking whether a tool was installed returned a non-zero exit value
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Remove checks against returncode in subprocess calls for is_tool_installed methods that would raise a CalledProcessError.
Add test case to check return value of is_tool_installed when attempting to check for tool with known bad flag that will return non-zero exit code.
Anyone you think should look at this, specifically?
@whyitfor
One sentence summary of this PR (This should go in the CHANGELOG!) Fix bug where Component External Tool would raise an error when checking whether a tool was installed returned a non-zero exit value
Link to Related Issue(s) N/A
Please describe the changes in your request. Remove checks against returncode in subprocess calls for
is_tool_installedmethods that would raise aCalledProcessError. Add test case to check return value ofis_tool_installedwhen attempting to check for tool with known bad flag that will return non-zero exit code.Anyone you think should look at this, specifically? @whyitfor