search

redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

Bump importlib-metadata version #296

Closed rbs-jacob closed 1 year ago

rbs-jacob commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!)

Running pip install ofrak installs version 3.0.0 and, for some reason, seems to install the lowest possible version of importlib-metadata (1.4.0). This old version does not actually support all of the features of the library we are using. This PR bumps the version.

Anyone you think should look at this, specifically?

@whyitfor

whyitfor commented 1 year ago

@rbs-jacob, shouldn't we have a bugfix in the changelog? This could end up being 3.0.1.

rbs-jacob commented 1 year ago

@rbs-jacob, shouldn't we have a bugfix in the changelog? This could end up being 3.0.1.

I wasn't sure about updating the changelog, because I'm not sure if this qualifies as a 3.0.0 post release, or whether it's a minor version bump of its own. Sounds like you want me to update it, though.

whyitfor commented 1 year ago

I wasn't sure about updating the changelog, because I'm not sure if this qualifies as a 3.0.0 post release, or whether it's a minor version bump of its own. Sounds like you want me to update it, though.

@rbs-jacob, this seems like something that should go in "Fixed" in a change log. It isn't a minor version but a patch version bum, so it would be released as 3.0.1. Please add a "Fixed" entry in the change log.