redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

Remove linux-setup.sh step from BinaryNinja headless install #305

Closed whyitfor closed 1 year ago

whyitfor commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Remove linux-setup.sh from BinaryNinja headless install steps.

Please describe the changes in your request. The linux-setup.sh step was not working; it is not actually needed for a headless install of BinaryNinja in Docker. It was therefore removed.

I've tested the change and validated the OFRAK BinaryNinja tests pass in the built Docker image.

Anyone you think should look at this, specifically? @EdwardLarson