redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

Feature/load and run script #310

Closed EdwardLarson closed 1 year ago

EdwardLarson commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Add a Modifier and associated GUI button/view to upload a Python file and run a function in that file on the selected Resource

Link to Related Issue(s)

Please describe the changes in your request.

TODO:

Anyone you think should look at this, specifically?

EdwardLarson commented 1 year ago

@whyitfor What do you think of gating this behind the "Experimental Features" checkbox? We were talking about it at standup today, and all of us could go either way.

On the one hand, in some ways it is simpler than running any component, since we only need one simple config to be properly serialized/deserialized. On the other hand, there could be a lot of "weird" side effects running scripts.

marczalik commented 1 year ago

@whyitfor What do you think of gating this behind the "Experimental Features" checkbox? We were talking about it at standup today, and all of us could go either way.

On the one hand, in some ways it is simpler than running any component, since we only need one simple config to be properly serialized/deserialized. On the other hand, there could be a lot of "weird" side effects running scripts.

@EdwardLarson As mentioned offline, if we know that the UI/UX will change significantly for this feature that may be a good reason to set it behind "Experimental Features" for now. Regarding the fact that it's not an API-level change, I still think it's a good idea to inform users ahead of time if we know that something is being shipped "unfinished" and that seems like what "Experimental Features" should be.

whyitfor commented 1 year ago

@EdwardLarson, if we are on the fence then let's put it behind the "experimental" config.