search

redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

Moderate Speedups #315

Closed rbs-jacob closed 1 year ago

rbs-jacob commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!)

This PR adds some moderate speedups to OFRAK.

Anyone you think should look at this, specifically?

@EdwardLarson @whyitfor

rbs-jacob commented 1 year ago

Looks like some tests are not passing?

I'd suggest limiting the scope of this PR to the changes in resource_model.py (that should go in relatively quickly).

I can see the context change being one that might need more discussion.

The changes outside of resource_model.py are the most impactful. I'd go as far as to say that this PR isn't worth merging on its own without those changes. I think it makes the most sense to try and get the tests to pass, since it only looks like four are failing.