redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 127 forks source link

bump black version #323

Closed EdwardLarson closed 1 year ago

EdwardLarson commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Bump black version to avoid spurious import-time errors with INFO logging level.

Link to Related Issue(s)

With the logging level set to INFO, at import time, black generates some errors about missing cache etc. These are completely inconsequential but do look a bit nasty (error file not found etc.) so could concern/confuse users. The issue in black is documented here: https://github.com/psf/black/pull/3193

It has been resolved (making these errors show up with DEBUG log level only, which is fine I guess) but we are on an older version which doesn't include these changes.

Please describe the changes in your request.

Anyone you think should look at this, specifically?

ANogin commented 1 year ago

@Edward-Larson this created an inconsistency - ofrak_core requires black==23.3.0, but ofrak_io (ofrak_io/setup.py) still has black==22.6.0.

P.S. We should land https://github.com/redballoonsecurity/ofrak/pull/218 eventually to make it possible to detect these kinds of issues in CI tests