Closed EdwardLarson closed 1 year ago
Definitely remaining TODO:
ghidra://
or http://
prefix is now added automatically to the hostname) so that pulling/updating this wont break existing setupsPossible remaining TODO:
The main issue with that is that you probably want to leave it up when doing some development with ofrak_ghidra, so you don't have to be constantly starting/stopping the repository server. So maybe the repository should be left alive when OFRAK exits. This is already essentially the case so it should be benign to do so.
(Decided to punt on this to potential future PR to avoid scope creep on this one)
One sentence summary of this PR (This should go in the CHANGELOG!) Actually use the fields of the ofrak_ghidra.config when setting up the ghidra repository
Link to Related Issue(s) Basically we had infrastructure to configure ofrak for a local ghidra setup, but the ofrak_ghidra code was not looking at that config at all.
Please describe the changes in your request.
Anyone you think should look at this, specifically?