redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

Feature/ppcvletoolchain #338

Open paulnoalhyt opened 1 year ago

paulnoalhyt commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Support for PPC VLE in patchmaker and Ghidra.

Link to Related Issue(s) https://github.com/redballoonsecurity/ofrak/issues/238

Please describe the changes in your request. This pull request's goal is to add support for PPC VLE in different OFRAK components:

Anyone you think should look at this, specifically? @rbs-jacob

rbs-jacob commented 1 year ago

Instead of #341 for allowing secrets (which may or may not work), maybe we can just mark the PPC VLE stuff with # pragma: no cover and not be blocked on that?

Test coverage is all well and good, but I don't know how much we want to block on it for this. There will still be test coverage after merge on the master branch (where secrets will work), just not on PR branches from external contributor forks.