redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

ofrak_patch_maker no longer looks for toolchain.conf in "/etc". #342

Closed whyitfor closed 1 year ago

whyitfor commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) ofrak_patch_maker does not look for toolchain.conf in /etc.

Link to Related Issue(s) This issue partially addresses problems raised in #340.

Please describe the changes in your request. ofrak_patch_maker initially assumed that the toolchain.conf was in /etc.

When the package was added to PyPI, the toolchain.conf started to get bundled with the package itself. Given this, there is no need to search for toolchain.conf. This PR removes this logic entirely: toolchain.conf is only searched for in the ofrak_patch_maker package.

This change makes local installs easier, as copying the toolchain config to /etc often required root privileges.

Anyone you think should look at this, specifically? FYI @ANogin, @Jepson2k.