redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

Save resources affected by data patches and dependency updates on a re… #355

Closed EdwardLarson closed 1 year ago

EdwardLarson commented 1 year ago

…source being saved

One sentence summary of this PR (This should go in the CHANGELOG!) Save resources affected by data patches and dependency updates on a resource being saved

Link to Related Issue(s) Calling resource.save() will apply data patches, which for mapped resources will also modify one or more ancestors. Without these changes, those resources would be marked as "dirty" after the original save call. This has the confusing result of making local state overall "dirtier" after a save call, rather than less.

Please describe the changes in your request. With these changes, if save call on one resource modifies other resources, those resources' models will also be pushed and not dirty.

Anyone you think should look at this, specifically? @dannyp303