search

redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

isolate non-python dependencies #357

Closed EdwardLarson closed 1 year ago

EdwardLarson commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!)

Link to Related Issue(s) I added the bincopy dependency to the requirements.txt as a github link, but it turns out that blocks PyPI:

ERROR: Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI. ofrak depends on bincopy@ git+https://github.com/eerimoq/bincopy.git@17.14.5

So I've moved bincopy (and binwalk) into a requirements-non-pypi.txt, and a pip extras rule for them under "non-pypi", which is installed in the build-image.py. I also added the necessary ComponentExternalTool and protections in the ihex components which use bincopy.

Please describe the changes in your request.

Anyone you think should look at this, specifically?