redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

Update IhexIdentifier to only search for one match. #359

Closed whyitfor closed 1 year ago

whyitfor commented 1 year ago

One sentence summary of this PR (This should go in the CHANGELOG!) Bugfix in Intel Hex identifier to avoid regex matching the entire file.

Link to Related Issue(s) N/A.

Please describe the changes in your request.

These changes avoid matching on entire contents of a file encoded in Intel Hex format, making identification run faster.

Anyone you think should look at this, specifically? @EdwardLarson