redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

Maintenance: Install python-lzo from pip #376

Closed EdwardLarson closed 11 months ago

EdwardLarson commented 11 months ago

One sentence summary of this PR (This should go in the CHANGELOG!) Move/"promote" python-lzo module from an external dependency of the Ubi and Ubifs components to a normal pip dependency

Link to Related Issue(s) Not sure why python-lzo was marked as an external dependency originally, but it seems erroneous. It of course adds an extra dependency not installed as part of a pip install.

Please describe the changes in your request. Remove that dependency object and installation line in Dockerstub, add it to requirements.txt. Also make a small change to one of the ofrak server tests, that sometimes causes a problem (this error).

Anyone you think should look at this, specifically?

rbs-jacob commented 11 months ago

I don't know if this is why, but vmlinux-to-elf pins a specific Git commit of python-lzo. Just FYI.

whyitfor commented 11 months ago

@EdwardLarson , IIRC, the issue is that:

If this is true, then the changes in the PR could make the pip install of ofrak possibly fail on systems without these headers.

Since python-lzo is used directly by ubireader, and not used by OFRAK, I believe you decided in #183 to install it this way.